search

w3c / webdriver

Remote control interface that enables introspection and control of user agents.
https://w3c.github.io/webdriver/
Other
676 stars 190 forks source link

Add deserialization steps for web frame and web window #1738

Closed whimboo closed 8 months ago

whimboo commented 1 year ago

While implementing the serialization of window and frame objects I noticed that there are no deserialization steps available for these two object types.

Preview | Diff

whimboo commented 1 year ago

@jgraham mind reviewing as well? Thanks.

whimboo commented 11 months ago

@mathiasbynens could someone from Google review this addition as well? I'm not sure who to tag given that @sadym-chromium is out at the moment.

whimboo commented 11 months ago

@jgraham fixes for both of your comments have been pushed.

whimboo commented 8 months ago

@jgraham merging this PR is blocked on your review comments. Can you please re-check if you have the time? Thanks.

whimboo commented 8 months ago

@jgraham merging this PR is blocked on your review comments. Can you please re-check if you have the time? Thanks.

Given that the review comments from James have been addressed, maybe @juliandescottes or @lutien can have a final look at the review?

whimboo commented 8 months ago

Please note that tests will be added as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1274251.