search

w3c / webdriver

Remote control interface that enables introspection and control of user agents.
https://w3c.github.io/webdriver/
Other
676 stars 190 forks source link

Fix reference for element disabled #1769

Closed whimboo closed 6 months ago

whimboo commented 7 months ago

To properly check an element for disabled we have to reference the actually disabled section of the HTML spec.

It means the link changes from https://html.spec.whatwg.org/#concept-fe-disabled to https://html.spec.whatwg.org/#concept-element-disabled.

@jgraham can you please review?

Preview | Diff

whimboo commented 7 months ago

@sadym-chromium, @gsnedders, @AutomatedTester, @shs96c could you please review this change? While browsers may still use the Is Element Enabled atom this brings us closer to a world without the Is Element enabled atom from Selenium.

Thanks.

whimboo commented 6 months ago

@sadym-chromium, @gsnedders, @AutomatedTester, @shs96c could you please review this change? While browsers may still use the Is Element Enabled atom this brings us closer to a world without the Is Element enabled atom from Selenium.

I would appreciate feedback for this change from those listed above. Are you ok with this change or do you have objections? Thanks.

whimboo commented 6 months ago

Thank you all for the reviews. I think that we basically have enough reviews from different stake holders that we can get the PR merged.