search

w3c / webdriver

Remote control interface that enables introspection and control of user agents.
https://w3c.github.io/webdriver/
Other
676 stars 190 forks source link

Fix issues with User Prompt Handler after PR #1791 #1812

Closed whimboo closed 1 month ago

whimboo commented 1 month ago

With PR #1791 we got extended support for the unhandledPromptBehavior landed which added a new Object type to define handlers for all the prompt handlers more granularly.

While implementing the capability handling for that new type in Firefox I noticed a couple of issue. This PR fixes these and also updates some cases to make it better understandable what specific variables actually are.

FYI @sadym-chromium @nechaev-chromium @gsnedders for when you get started to implement these changes in the drivers.

Updated tests will be part of my work on https://bugzilla.mozilla.org/show_bug.cgi?id=1895738.

Preview | Diff

whimboo commented 1 month ago

@OrKoN mind a quick review as well? Thanks a lot.