search

w3c / webdriver

Remote control interface that enables introspection and control of user agents.
https://w3c.github.io/webdriver/
Other
685 stars 195 forks source link

`Dispatch a pointer down action` has invalid parameters #1817

Closed ChernyshevDS closed 5 months ago

ChernyshevDS commented 5 months ago

Dispatch a pointerDown action does not accept input source as a parameter. It seems that input source is mixed up with input state, because following items do not make sense because input source does not have expected properties:

  1. If the input state's pressed property contains button return success with data null.

  2. Let x be equal to input state's x property.

  3. Let y be equal to input state's y property.

  4. Add button to the set corresponding to input state's pressed property, and let buttons be the resulting value of that property.

whimboo commented 5 months ago

@ChernyshevDS thanks for reporting the issue. Checking the table of action algorithms and how to dispatch those it is clear that the second argument indeed has to be the source. You can see this as well for the Dispatch a pointerUp action case.

Would you be interested to fix this bug in the specification? We would appreciate.

ChernyshevDS commented 5 months ago

@whimboo Sure, I've created a PR: https://github.com/w3c/webdriver/pull/1820

whimboo commented 5 months ago

Fixed by #1820.