search

w3c / webdriver

Remote control interface that enables introspection and control of user agents.
https://w3c.github.io/webdriver/
Other
682 stars 195 forks source link

"Release Actions" doesn't yet use the queuing mechanism for actions #1837

Open whimboo opened 1 month ago

whimboo commented 1 month ago

While implementing the queuing mechanism for Actions in our WebDriver BiDi code base for Firefox I noticed that for the Release Actions command we are just trying to run tick actions, but do not queue this up as a task. That means running a Release Actions command in parallel to the Perform Actions command in BiDi will immediately trigger the release of inputs which in most cases will be a no-op and later on will not reset the inputs unless the browsing context (navigable) gets closed or Release Actions is called again.

I'm going to add a wdspec test for both commands as part of my work on https://bugzilla.mozilla.org/show_bug.cgi?id=1915798.

whimboo commented 1 month ago

Also the retrieval of the undo actions in Release Actions need to happen within the queued task. Otherwise there might be nothing to undo for the release action.