search

w3c / webextensions

Charter and administrivia for the WebExtensions Community Group (WECG)
Other
595 stars 56 forks source link

action.onUserSettingsChanged proposal #499

Closed EmiliaPaz closed 8 months ago

EmiliaPaz commented 10 months ago

Proposal based on w3c#346: New API: UserSettings.isOnToolbar change event

bershanskiy commented 10 months ago

This API permits addition of new observers, but not removal of old ones: action.onUserSettingsChanged().

Instead, it could match the established pattern of <eventName>.addListener() and <eventName>.removeListener() and become action.onUserSettingsChanged.addListener() and action.onUserSettingsChanged.removeListener().

oliverdunk commented 10 months ago

Instead, it could match the established pattern of <eventName>.addListener() and <eventName>.removeListener()

Thanks for the callout. I'll make sure @emilia-paz sees this but I suspect it is just a mistake in the proposal. We would almost certainly want to follow the normal event listener pattern here :)

oliverdunk commented 9 months ago

@zombie / @dotproto / @xeenon - could you take a look at this?