search

w3c / webidl2.js

WebIDL parser
https://w3c.github.io/webidl2.js/checker/
MIT License
239 stars 62 forks source link

Remove deprecated void support #784

Open nektro opened 3 weeks ago

nektro commented 3 weeks ago

https://github.com/w3c/webidl2.js/blob/83fffdb/test/invalid/idl/void-keyword.webidl#L1-L4

removed here https://github.com/whatwg/webidl/pull/906

saschanaz commented 3 weeks ago

Hmm? That's literally "invalid" idl 👀

saschanaz commented 3 weeks ago

But it's true that it's overdue of this void thing, I'll remove the void support completely. I don't think that specific test will change, though.

nektro commented 3 weeks ago

right but since void isnt a keyword anymore its validly parsed as an identifier (granted one that doesnt match to anything, but that would only be found out at a later step) (i suppose the validator here could be doing that but mine wasn't which is what led to the confusion)

Definitions Definition CallbackOrInterfaceOrMixin InterfaceOrMixin InterfaceRest InterfaceMembers InterfaceMember PartialInterfaceMember Operation RegularOperation Type SingleType DistinguishableType identifier

nektro commented 3 weeks ago

similar to how the following passes on https://w3c.github.io/webidl2.js/checker/

[Exposed=Window]
interface Foo {
  Bar foo();
};
saschanaz commented 3 weeks ago

Oh right, yes. Good point, thank you.