search

w3c / webpayments

The document repo for the Web Payments Working Group
https://github.com/w3c/webpayments/wiki
Other
256 stars 62 forks source link

Sepamail WebIDL syntax and algorithms #219

Closed rsolomakhin closed 6 years ago

rsolomakhin commented 7 years ago

I suggest the following changes in in sepamail proposal:

  1. The type of supportedNetworks should change from sequence to sequence<DOMString>.
  2. The type of supportedTypes should change from sequence to sequence<BasicSepamailType>.
  3. The name of SelectedNetwork should change to selectedNetwork.
  4. The name of SelectedType should change to selectedType.

Also, please add some algorithms to process BasicSepamailRequest in the browser. At the very least, please specify what should happen if supportedNetworks or supportedTypes is an empty list. What should happen if supportedNetworks contains empty or duplicate strings. (I suggest throwing TypeError in all those cases.)

marcoscaceres commented 7 years ago

sepamailIdentifier should just be "id"

ianbjacobs commented 7 years ago

I believe Cyril has integrated comments: https://w3c.github.io/webpayments/proposals/sepamail.html

(Cyril has asked Rouslan to verify.)

rsolomakhin commented 7 years ago

Looks good, thank you.

ianbjacobs commented 6 years ago

We have not worked on the sepamail proposal for a long time so closing this for now.