w3c / webpayments

The document repo for the Web Payments Working Group
https://github.com/w3c/webpayments/wiki
Other
256 stars 62 forks source link

Adopt a "test as you commit" policy #234

Closed rakuco closed 6 years ago

rakuco commented 6 years ago

An increasing number of groups are beginning to make web-platform-tests part of their day-to-day work, and more are considering it, for example in w3c/dap-charter#48. https://github.com/foolip/testing-in-standards/blob/master/policy.md has some additional context, and https://github.com/w3c/accelerometer/pull/29 is an example of the changes we've been landing.

I can see that the payment-requests repository already has something similar in place in https://github.com/w3c/payment-request/blob/gh-pages/test-plan.md; I was wondering if you'd be open to doing the same to the other repositories:

marcoscaceres commented 6 years ago

Just noting the payment request test plan is not great (doesn't actually cover what we do)... The WHATWG work mode cover things better: https://whatwg.org/working-mode

marcoscaceres commented 6 years ago

@rakuco, we are trying to do what mentioned above here: https://github.com/w3c/wg-effectiveness/issues/21

Could definitely use some help with that to help make it a W3C wide policy! It will take time, but a lot of us a trying to name it happen.

rakuco commented 6 years ago

That seems to be in line with what @foolip and I have been trying to do by adding the "test as you commit" policy to multiple specs lately, so I think we're all on the same page here. In this case, do you have any objections to what I outlined above?

foolip commented 6 years ago

@marcoscaceres, will this be a discussion at TPAC? Can I observe the session?

marcoscaceres commented 6 years ago

Let's just find a time to chat on Wednesday? There are a few talks happening around testing then.

foolip commented 6 years ago

Sure. There's a breakout session about web-platform-tests then, but I'll come to wherever the discussion is. (I'm flying on the afternoon though.)

foolip commented 6 years ago

@marcoscaceres, is the group having a meeting on Wednesday? I guess the group needs to make a resolution on this?

marcoscaceres commented 6 years ago

If you mean Payments, we are meeting today... but there is no need for a resolution - it's now basically baked into our process as all the editors agreed to do it.

ianbjacobs commented 6 years ago

I believe this is a policy that the editors of various specs have adopted; closing.

marcoscaceres commented 6 years ago

Agree! It’s been a really great shift and wonderful to see it working well.