search

w3c / webrtc-encoded-transform

WebRTC Encoded Transform
https://w3c.github.io/webrtc-encoded-transform/
Other
122 stars 26 forks source link

Add an API for a "keyframe has been requested" event #215

Closed alvestrand closed 7 months ago

alvestrand commented 7 months ago

This is split from #207 - in the October interim discussion, the overall congestion control API was seen as requiring more discussion, but the keyframe proposal was thought reasonable to pursue on its own.

I preserved the split into "ScriptSource" and "ScriptSink" interfaces - I think that can be valuable for documenting which interfaces are facing in which direction on the transformer.

Comments welcome.

Preview | Diff

alvestrand commented 7 months ago

Fixes #210

jan-ivar commented 7 months ago

LGTM if @youennf agrees.

alvestrand commented 7 months ago

Waiting for @youennf

alvestrand commented 7 months ago

Mixins removed as agreed during the editors meeting. I also tightened up the definition of what to do when the keyframerequest event fires. Should be ready to merge now - hope to merge it before the WG meeting Tuesday, so that we can say "it is done".

alvestrand commented 7 months ago

Despite bikeshed refs --for=Event --text='canceled flag' returning a value (spec=dom), I'm unable to make {{Event/canceled flag}} autolink. @dontcallmedom help?

dontcallmedom commented 7 months ago

the correct syntax would be [=Event/canceled flag=] - the {{ }} syntax is only for WebIDL terms, when "canceled flag" is a regular definition (see relevant Bikeshed doc)

alvestrand commented 7 months ago

the correct syntax would be [=Event/canceled flag=] - the {{ }} syntax is only for WebIDL terms, when "canceled flag" is a regular definition (see relevant Bikeshed doc)

Thanks - that worked. I could have sworn that I tried that before!

dontcallmedom-bot commented 7 months ago

This issue was discussed in WebRTC December 12 2023 meeting – 12 December 2023 (Keyframe API)