search

w3c / webrtc-encoded-transform

WebRTC Encoded Transform
https://w3c.github.io/webrtc-encoded-transform/
Other
122 stars 27 forks source link

Clarification on "not processing video packets" requested #230

Open luciaalonsomozo opened 4 weeks ago

luciaalonsomozo commented 4 weeks ago

What does processing mean in step 2 of send key frame algorithm?

luciaalonsomozo commented 4 weeks ago

It seems from this Web Platform Test that inactive and stopped transceivers would cause this error, is that what step 2 is referring to? Could it be made more explicit?

alvestrand commented 4 weeks ago

spec link to editors' draft: https://w3c.github.io/webrtc-encoded-transform/#KeyFrame-algorithms

alvestrand commented 4 weeks ago

Seems to be intended to mean "if the media type of the encoder is not video".

guidou commented 4 weeks ago

WPT report says Firefox passes 6/6 and Safari 5/6.

https://wpt.fyi/results/webrtc-encoded-transform/script-transform-sendKeyFrameRequest.https.html?label=experimental&label=master&aligned

jan-ivar commented 4 weeks ago

Aligning with implementations seems good here.

jan-ivar commented 4 weeks ago

@youennf does that SGTY?

fippo commented 4 weeks ago

This simply means that one should not send RTCP for inactive or stopped m-lines, no? Given that RTCP is not reliable and one can not determine whether this was received anyway, why do browsers attempt to impose behavior on top here?