search

w3c / webrtc-extensions

A repository for experimental additions to the WebRTC API
https://w3c.github.io/webrtc-extensions/
Other
58 stars 19 forks source link

Rename setSelectedCandidatePair and return a promise #183

Closed sam-vi closed 10 months ago

sam-vi commented 11 months ago

Fixes #178. Fixes #182.

setSelectedCandidatePair is renamed to selectCandidatePair to indicate that the method is taking some action rather than immediately updating internal state.

The returned promise resolves when all changes performed by the method have been applied and relevant events have fired.

Preview | Diff

sam-vi commented 11 months ago

cc: @jan-ivar @henbos

PS this will need some conflict resolution once #181 is merged.

pthatcher commented 11 months ago

LGTM

henbos commented 10 months ago

@sam-vi Please resolve the merge conflicts and then feel free to click "merge!" (or ask me to)

henbos commented 10 months ago

Merging on behalf of Sameer using the editors can integrate label