search

w3c / webrtc-pc

WebRTC 1.0 API
https://w3c.github.io/webrtc-pc/
Other
433 stars 115 forks source link

Redefine SendCodecs and ReceiveCodecs #2935

Closed alvestrand closed 4 months ago

alvestrand commented 5 months ago

to contain all supported codecs, revealing only those that are "enabled" at any given time.

Fixes: #2925

Preview | Diff

alvestrand commented 5 months ago

Not sure "editorial" is correct here. It does document the existing browser behavior that implemented but not announced codecs are revealed when they are specifically asked for. But it unblocks the check.

alvestrand commented 4 months ago

WG discussion on Feb 20, 2024: Looks like an improvement.

dontcallmedom-bot commented 4 months ago

This issue had an associated resolution in WebRTC February 2024 meeting – 20 February 2024 (Modify the codec description model to ease describing changes #2925 #2935):

RESOLUTION: Bring #2935 for merging to editors meeting

alvestrand commented 4 months ago

From @jan-ivar : link definition of "enabled" to a dfn so that what it is is defined in one place.

alvestrand commented 4 months ago

Hoisting the @dontcallmedom flag. Can't figure out how to run respec locally to get the error message that listAmendments is complaining about.

dontcallmedom commented 4 months ago

FYI: what was missing was the step of 1 of the amendment markup process - adding the id of the changed section to base-rec.html.

alvestrand commented 4 months ago

Thank you @dontcallmedom ! (and for reminding me of the documentation link!!)

dontcallmedom commented 4 months ago

are there tests associated with this pull request? I would document them in #2910 (and if not, we should track the need to create them)