search

w3c / webrtc-pc

WebRTC 1.0 API
https://w3c.github.io/webrtc-pc/
Other
438 stars 115 forks source link

Write WPT to check RTCIceCandidatePair is now an interface #2978

Closed jan-ivar closed 5 months ago

jan-ivar commented 5 months ago

From #2961:

this is the kind of PR that updates the IDL fragments on which the idl harness relies: https://github.com/web-platform-tests/wpt/pull/46056

again, the WPT PR would only get generated some days after this WebRTC PR gets merged, so let's not block on it (but instead, let's file an issue when this PR gets merged)

The idl harness will hopefully test window.RTCIceCandidatePair exists, but we should expound on existing WPT webrtc tests to check that what's being returned by UAs are instanceof the right type. cc @sam-vi

dontcallmedom commented 5 months ago

I think https://github.com/web-platform-tests/wpt/pull/46655 accomplishes what we need (although without actual implementation, it's a bit hard to verify)