search

w3c / webrtc-respec-ci

Script to run continuous integration on a respec-based spec
2 stars 14 forks source link

Make "make tidy" strip trailing spaces #24

Closed alvestrand closed 6 years ago

vivienlacourba commented 6 years ago

@alvestrand I was under the impression that html tidy was already taking care of removing the trailing whitespaces but trying on webrtc-pc/webrtc.html it missed one such occurrence and also missed 3 occurences on mediacapture-main/getusermedia.html.

Common thing is that in all cases the following line start with an html comment tag <!--. So that seems more like something that need to be fixed in https://github.com/htacg/tidy-html5/

The relevant code seems to be tidy-html5/src/parser.c : CleanTrailingWhitespace() function.

Let me know if this C code speaks to you otherwise I'll try to reproduce this with a simpler example and then submit a bug report.

vivienlacourba commented 6 years ago

In the meantime we can merge your changes but I'd like to have your thoughts first.

alvestrand commented 6 years ago

As you suspected, there's a bug in "make tidy" that leaves an extra space on lines where the next line consists of a HTML comment. This is a workaround for that bug. Would be happy if you can submit the bug and pursue. I've known about it for a long time and haven't gotten around to it. Please merge this in the meantime.