search

w3c / webrtc-stats

WebRTC Statistics
https://w3c.github.io/webrtc-stats/
Other
130 stars 47 forks source link

wrong definition of RTCIceServerStats.protocol? #512

Closed fippo closed 4 years ago

fippo commented 5 years ago

The definition of RTCIceServerStats.protocol seems to be copied from another place, most likely this one:

    Valid values for transport is one of udp and tcp. 
    Based on the "transport" defined in [RFC5245] section 15.1.

which is the protocol used by the candidate. We're rather interested in the protocol used to connect to the TURN server to say "how long is the RTT for this udp turn server", no? I.e. we want relayProtocol:

It is the protocol used by the endpoint to communicate with the TURN server.
This is only present for local candidates. Valid values are udp, tcp, or tls.

We could obviously extract that from the url but...

chore task: all the references to 5245 need to be updated :-|

vr000m commented 5 years ago

@lennart-csio Please take a look

lennart-csio commented 5 years ago

the intention is indeed to have the protocol to connect to the server, i will clarify. @fippo what do you mean by the core task? at least in the RtcIceServerStats dict there is only this one reference. should it be a task in this issue to go through all references to the RFC and check if its accurate?

fippo commented 5 years ago

@lennart-csio, chore, not core. RFC 5245 got obsoleted by 8445 so all references to the old one need to be updated eventually. Which is incredibly boring ;-)

lennart-csio commented 5 years ago

thanks for clarifying :) i will do the fix first as a PR, then we can see if we want to have another issue for updating the RFC reference or not