w3c / wot-binding-templates

Web of Things (WoT) Binding Templates
http://w3c.github.io/wot-binding-templates/
Other
23 stars 25 forks source link

Some very minor editorial issues #285

Closed danielpeintner closed 1 year ago

danielpeintner commented 1 year ago

Please find some minor issues I fixed in this PR.


Besides that some more feedback:

Figure 1

White text in yellow box is hard to read

4. Binding Template Mechanisms

TDs can bound to specific protocols --> TDs can be bound to specific protocols ??? (Not sure but to me the "be" is missing)

JSON Formatting

Some examples are not nicely formatted, e.g.;:


Preview | Diff

netlify[bot] commented 1 year ago

Deploy Preview for wot-binding-templates ready!

Name Link
Latest commit 4da77cd51d704625d448fe116b539eeac1fb8c7a
Latest deploy log https://app.netlify.com/sites/wot-binding-templates/deploys/643ff03b636056000817f6e8
Deploy Preview https://deploy-preview-285--wot-binding-templates.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

egekorkan commented 1 year ago

Regarding Figure 1 feedback: that is actually copied directly from Architecture but I can change it here. It should be changed there too.

I agree with the rest of the feedback. @danielpeintner could you pack them to this PR or create an issue for them?

danielpeintner commented 1 year ago

Regarding Figure 1 feedback: that is actually copied directly from Architecture but I can change it here. It should be changed there too.

👍

I agree with the rest of the feedback. @danielpeintner could you pack them to this PR or create an issue for them?

I updated the PR. Please check again. W.r.t. JSON formatting I just fixed some easy issues.. not sure whether we want to use a given style