w3c / wot-binding-templates

Web of Things (WoT) Binding Templates
http://w3c.github.io/wot-binding-templates/
Other
23 stars 25 forks source link

Min Polling Interval in CoAP #352

Closed ektrah closed 8 months ago

ektrah commented 9 months ago

Resolves #349

netlify[bot] commented 9 months ago

Deploy Preview for wot-binding-templates ready!

Name Link
Latest commit 3713e2d241b579d09ca99f5792c9bb2cdc67ea31
Latest deploy log https://app.netlify.com/sites/wot-binding-templates/deploys/65f20011904d66000872baeb
Deploy Preview https://deploy-preview-352--wot-binding-templates.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

egekorkan commented 9 months ago

In the call of 22.02, we have agreed on the content change. @egekorkan will fix the tooling to use the turtle file in the generation of the index.html

egekorkan commented 8 months ago

I have done the changes as agreed upon. Looking at https://github.com/w3c/wot-binding-templates/pull/352/commits/97156717b5528b39ade19360ee4ff167fca0c2ec there is no real change in the index.html. I have also added this field to json schema

egekorkan commented 8 months ago

@ektrah and @JKRhb can you have a final look and give ok? We can merge it asynchronously :)

egekorkan commented 8 months ago

@JKRhb if fine with you as well, you can merge it :)

JKRhb commented 8 months ago

@JKRhb if fine with you as well, you can merge it :)

Thank you, Ege, looks good to me! :)