search

w3c / wot-cg

Web of Things Community Group
https://www.w3.org/community/wot/
Other
16 stars 10 forks source link

First and Second videos', text and vtt. #46

Closed idilsezgin closed 1 year ago

idilsezgin commented 1 year ago

First and Second videos', text and vtt.

egekorkan commented 1 year ago

The PRs #44 and #45 seems to have been closed due to IPR checks. There is no need to close them, we can ask for a revalidation once the w3c linking issue is solved by the PR submitter. This PR looks good but we need a readme.

Also, I have realized that we may need a folder where we merge and move to the final folder for publication to YouTube. Otherwise, people need to review the document while they are in the PR area, which might be annoying for some. It is a bit against git principles though... @relu91 any opinions?

Side note: It may actually increase the repository size if we put a file and move it since moving a file is not a git operation afaik. This means that we will have removal and addition of a big file, thus a big .git folder size when cloning.

jyhi commented 1 year ago

a folder where we merge and move to the final folder

Use a branch :)

There are two ways:

  1. Require all PRs to go into an e.g. staging branch first, in which we do our work, and merge it back to main.
  2. Just review in PR, and I think this is actually an intended use case of PR. For local operations, a PR can also be accessed by a remote ref pull/<#ID>/head: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally and there is better facility to intuitively review contents.
egekorkan commented 1 year ago

@jyhi thanks for the opinions. I think that the second option is indeed better (not leaving the PR environment). For those who are reviewing, I propose to put comments on the vtt file if they have remarks for the text or for the video. That way, we know which seconds to look at even if it is feedback about the visuals.

Note: In VLC Player, the subtitles (vtt file) are automatically added so it makes it easier to review everything at once.

egekorkan commented 1 year ago

WoT.vtt is picked automatically, while Payload-and-headers.vtt no. It's weird.

There was a typo with the filenames (- vs .)

idilsezgin commented 1 year ago

@relu91, changes are made. Could you please take a look?