feat!(typescript): align TypeScript definitions with Discovery API

w3c / wot-scripting-api

Web of Things (WoT) Scripting API

http://w3c.github.io/wot-scripting-api/

Other

42 stars 28 forks source link

Closed JKRhb closed 1 year ago

JKRhb commented 1 year ago

In the context of https://github.com/eclipse-thingweb/node-wot/pull/864, I noticed that the TypeScript definitions are not taking into account the latest changes to the Scripting APIs discovery API (see https://github.com/w3c/wot-scripting-api/pull/405 and https://github.com/w3c/wot-scripting-api/pull/441). This PR should adjust the types accordingly – let me know if I missed anything :)

danielpeintner commented 1 year ago

Call Nov 06

@zolkis need to check whether we need constructor. Factory to use for async --> remove constructor for both cases, ConsumedThing as well
@zolkis should link "old" PR when we changed the spec itself (in first comment)
@JKRhb removing constructors is fine for me
@danielpeintner update version number of API, https://github.com/w3c/wot-scripting-api/blob/dc3a512bca7e858e6adc58be2b6762dd04194da7/typescript/scripting-api/package.json#L3

JKRhb commented 1 year ago

The PR should now be updated as discussed during today's meeting :) Let me know if there is anything that should be changed additionally.

danielpeintner commented 1 year ago

@JKRhb May I ask you to update the version to "0.8.0-SNAPSHOT.29" since "0.8.0-SNAPSHOT.28" has been used by https://github.com/w3c/wot-scripting-api/pull/522

JKRhb commented 1 year ago

@JKRhb May I ask you to update the version to "0.8.0-SNAPSHOT.29" since "0.8.0-SNAPSHOT.28" has been used by #522

Done :)

danielpeintner commented 1 year ago

Scripting Call Nov 20