search

w3c / wot-thing-description-toolchain-tmp

work area for WoT Thing Description toolchain
0 stars 1 forks source link

Testing of TD instance against created LinkML Schema #18

Closed mahdanoura closed 1 month ago

mahdanoura commented 2 months ago

This PR adds TD instances for testing the created LinkML Schema. The instances have been taken from TD Playground. Some improvements on the LinkML schema is also provided based on the example instances.

egekorkan commented 1 month ago

@TallTed thank you for the review! These examples are taken from https://github.com/eclipse-thingweb/playground/tree/master/examples/td and your feedback will be mirrored back there as well.

Also we have a meeting to talk about this new tooling every Wednesday 15:30 CEST. If you are interested, let me know :)

mahdanoura commented 1 month ago

Editorial, mostly punctation, typos, and grammar.

Thanks alot @TallTed for all the suggested changes. All the changes have now been applied.

TallTed commented 1 month ago

Also we have a meeting to talk about this new tooling every Wednesday 15:30 CEST. If you are interested, let me know :)

I usually have a conflict with Weds 09:30 ET (I'm in Massachusetts, USA), but no worries. My primary coding language is English, and my suggestions aren't usually time-sensitive, so I'm fine with doing occasional asynchronous reviews like I did here.