w3c / wot-thing-description

Web of Things (WoT) Thing Description
http://w3c.github.io/wot-thing-description/
Other
131 stars 63 forks source link

Prettier Formatter Version alignment and GH Action #1970

Closed egekorkan closed 5 months ago

egekorkan commented 7 months ago

Prettier does some basic formatting (like HTML Tidy but for other file types too). In this PR:

relu91 commented 7 months ago

Questions:

egekorkan commented 7 months ago

Questions:

  • As you acknoldge the are some unwanted changes, are we sure that they are just leftovers from the previous configuration?
  • Instead of having an action that does the formatting for you and commits, I would have an action that just verifies if the code is formatted and block the PR if it isn't. If we have hasky configured properly it the verification stage here will be always green and we avoid prettify commits.
egekorkan commented 6 months ago

Call of 27.03:

egekorkan commented 5 months ago

I have taken the reviews into account and this should now auto-format by overwriting the comment and not pollute the commit history.