w3c / wpub-ann

Web Annotation Extensions for Web Publications
https://w3c.github.io/wpub-ann/
Other
6 stars 10 forks source link

Extend Range Selector, add Multi Selector #23

Closed iherman closed 6 years ago

iherman commented 6 years ago

@tcole3 @BigBlueHat,

I had some empty time today, so I created this PR. It is based on my thoughts on what we had so far, and I believe that this design covers the use cases, namely:

It also seems to be semantically clean, avoiding some issues in my comments.

It required quite a number of changes on the document (see the list of changes below) so, I'm afraid, the diff file does not really make sense. But the preview might be fine.


Preview | Diff

iherman commented 6 years ago

Here is the list of changes:

(The last two items are not really dependent on this PR, but I did it on the fly; if we decide to reject this PR, that may have to be repeated on the master branch...)

tcole3 commented 6 years ago

The PR will allow us to discuss several issues, and so I would like to see it merged. The issues for me are:

Anyway, let's merge this PR now to facilitate discussion of these issues Tuesday afternoon.