w3c / wpub-ann

Web Annotation Extensions for Web Publications
https://w3c.github.io/wpub-ann/
Other
6 stars 10 forks source link

Is the modeling of the new Embedded Resource Selector consistent? #24

Closed iherman closed 6 years ago

iherman commented 6 years ago

Is the modeling of the new Embedded Resource Selector consistent with (i.e., a reasonable additional type of) the Selector class as defined by Web Annotations?

(Taken over from @tcole3’s comment)

iherman commented 6 years ago

I would argue it is. In example 10 you have a resource (MobyDick.wpub, a Web Publication) and you want to identify and reference a segment of it that happens to have it's own URL (moby-dick-book-cover.jpg). To me the fact that the segment has its own URL does not invalidate using a Selector to reference it, but this is arguable and needs to be discussed.

(From @tcole3’s comment)

iherman commented 6 years ago

I must admit I do not see a problem with ERS as a Selector...

Treora commented 6 years ago

One more thought, I forgot to add here: EmbeddedResourceSelector seems a most generic type of selector for any hypermedia documents (anything supporting some form of transclusion, I guess). It may be worth specifying it with a broader use in mind than WebPublications. For example, I could target an image in a document by its URL.

One situation I am thinking of is the case where specifying a URL is ambiguous: e.g. a document contains the same image twice. Just saying {"type": "EmbeddedResourceSelector", "value": "example.org/image"} may thus yield two results. Of course, another (document type-specific) selector could be used instead to point to the right instance (e.g. an XPathSelector), but it may be worth keeping the situation in mind.

Thinking this way, I wonder about other ways to point at embedded resources, by describing their relative relation to the document. If the link has a name, referring to that name may be a desirable way to point at the subresource it links to (somewhat like a path an IPFS URL). In fact, FragmentSelector may already serve this purpose quite well.

tcole3 commented 6 years ago

@Treora concern is orthogonal and has been opened as a new issue.

Otherwise satisfied that ERS is consistent with the Selector model, so closing this issue.