search

w3c / wpub-ann

Web Annotation Extensions for Web Publications
https://w3c.github.io/wpub-ann/
Other
6 stars 10 forks source link

Wa extensions #8

Closed iherman closed 6 years ago

iherman commented 6 years ago

Preview | Diff

iherman commented 6 years ago

This PR contains all the changes to the Selectors and States document and also to the WA model that was discussed. Namely

This PR closes #5, more exactly supersedes it. Note also Issue #2, which to see if the second addition to the document should remain or should be removed.

Similarly, this PR closes #4.

azaroth42 commented 6 years ago

I would flip the order of 3.10 (refinedBy) and 3.11 (EmbeddedResourceSelector) but otherwise it looks like a good first cut for discussion.

:+1:

iherman commented 6 years ago

I was wondering about that. My problem was that the EmbeddedResourceSelector example makes use of refinement, which may make the example a bit awkward. Maybe a simpler example for that selector and move the current one as an example for refinement.

However... I do not think the EmbeddedResourceSelector makes too much sense without a refinement...

Ideas?

azaroth42 commented 6 years ago

Good point. A simpler example for ERS could be:

{
  "type": "EmbeddedResourceSelector",
  "value": "/images/logo.jpg"
}

For a comment about the logo image embedded in the publication.

tcole3 commented 6 years ago

Are there any real-world use cases where a component (with its own URL) of a Web Publication is likely to appear (be embedded) in multiple locations within the Web Publication? If so, do any of these use cases require the ability to reference a particular occurrence of the component within the Web Publication? Originally I had thought we might be able to avoid need for ERS through the use of scope, but if we really need to define an ERS anyway, we want to make sure it sufficient to meet as many realistic use cases as possible.

iherman commented 6 years ago

{ "type": "EmbeddedResourceSelector", "value": "/images/logo.jpg" } For a comment about the logo image embedded in the publication.

An aside: you use a relative URL. For the moment ERS refers to URL.

I would propose to put in an issue whether a relative URL is allowed and what the base URL is. Let us get all other things out of the way first...

iherman commented 6 years ago

@azaroth42 @tcole3 @BigBlueHat: I will merge this PR. Not because it is a final version, but it may help us to do more fine-grained editings and PR-s.