search

w3c / wpub

W3C Web Publications
https://w3c.github.io/wpub/
Other
78 stars 19 forks source link

clarify resource list #313

Closed mattgarrish closed 6 years ago

mattgarrish commented 6 years ago

This PR removes the resource list from the required properties.

I also found the intro paragraph about the list confusing, as it seems to still have a mix of old ideas in it (mentioning "all resources" and then excluding resources, remnants of primary v secondary resources in mentioning the bounds). I've tried to simplify it, as well.

Preview | Diff

iherman commented 6 years ago

Ship it! :-)

HadrienGardeur commented 6 years ago

I'm not sure if this is on purpose but there's a pretty massive commit tied to this PR. Much easier to just review https://github.com/w3c/wpub/pull/313/commits/8f79ea2c8faee57019dbfd59b3bdb87310da8f5e

TzviyaSiegman commented 6 years ago

looks good!

mattgarrish commented 6 years ago

but there's a pretty massive commit tied to this PR

Ya, that was due to some fixes to the underlying markup, plus I use oxygen to make the line lengths more readable. It won't show up in the diff. Usually I try to do those directly in master.