w3c / wpub

W3C Web Publications
https://w3c.github.io/wpub/
Other
78 stars 19 forks source link

Moved the canonicalization out of the top level #355

Closed iherman closed 6 years ago

iherman commented 6 years ago

Did some editing to answer to the issues raised in #349. All changes are purely editorial.

Fix #349.


Preview | Diff

mattgarrish commented 6 years ago

A couple of comments:

mattgarrish commented 6 years ago

Also, rather than calling the section "Canonical Manifest" it might be helpful to provide a name that matches the lifecycle nature of the section, so something like "Generating a Canonical Manifest".

iherman commented 6 years ago

You are right on all accounts:-)

I have changed the order as you suggested, changed the title, and also modified the algorithm. Parsing is only done once, and the result of parsing (json) is input to the canonicalization step. There is also an additional remark in that algorithm that the input is a json object representing the manifest.

Thx:-)

mattgarrish commented 6 years ago

The processing section looks like it still needs some tweaks to accept a json object that is the canonical manifest rather than parsing text, but otherwise looks better now.

iherman commented 6 years ago

I will do that tomorrow morning and then merge. ok?

mattgarrish commented 6 years ago

sgtm