Closed iherman closed 6 years ago
A couple of comments:
Also, rather than calling the section "Canonical Manifest" it might be helpful to provide a name that matches the lifecycle nature of the section, so something like "Generating a Canonical Manifest".
You are right on all accounts:-)
I have changed the order as you suggested, changed the title, and also modified the algorithm. Parsing is only done once, and the result of parsing (json
) is input to the canonicalization step. There is also an additional remark in that algorithm that the input is a json object representing the manifest.
Thx:-)
The processing section looks like it still needs some tweaks to accept a json object that is the canonical manifest rather than parsing text, but otherwise looks better now.
I will do that tomorrow morning and then merge. ok?
sgtm
Did some editing to answer to the issues raised in #349. All changes are purely editorial.
Fix #349.
Preview | Diff