search

w3c / wpub

W3C Web Publications
https://w3c.github.io/wpub/
Other
79 stars 19 forks source link

Turned all occurences of PublicationLink to Linkedresource #362

Closed iherman closed 6 years ago

iherman commented 6 years ago

See discussion in #356, this is the PR embodying the outcome.

Fix #356 Fix #235

Preview | Diff

HadrienGardeur commented 6 years ago

This looks fine overall, but in the WebIDL definition of LinkedResource I see that description is a LocalizableString instead of a sequence<LocalizableString>.

Is that on purpose?

iherman commented 6 years ago

@HadrienGardeur that is already the case for the current official draft, ie, it is not specific to this PR.

To be honest, I do not remember why it was set to a single value instead of a sequence, but it is consistent with the definition. I would propose to de-associate this issue from this PR and raise it separately if you think it is a mistake.

HadrienGardeur commented 6 years ago

@iherman that's correct, I only noticed it today because I was specifically reviewing the section related to LinkedResource. I'll open a separate issue.

iherman commented 6 years ago

This is, essentially, an editorial PR (simple renaming), so I will merge and close this...