search

w3c / wpub

W3C Web Publications
https://w3c.github.io/wpub/
Other
79 stars 19 forks source link

Minor modification on the language and base direction section #439

Closed iherman closed 5 years ago

iherman commented 5 years ago

@dbaron had a comment in https://github.com/w3ctag/design-reviews/issues/344#issuecomment-485034489:

The description of default language and base direction seems a bit confusing. It seems to imply it's a default for the manifest and the publication, but then there's a note that says it only applies to the manifest and not to the resources that comprise the publication.

I agree it was not clear. I have moved the relevant note to the beginning of the section to make the distinction between the language/direction of the publication and the language/direction of the individual resources. I hope this change is enough.

I have also added an explicit reference to the issue on whether lang/dir is inherited when the manifest is embedded.

Preview | Diff

iherman commented 5 years ago

@dbaron, are you o.k. with this change, w.r.t. your comment?

iherman commented 5 years ago

@mattgarrish I would propose to merge this