search

w3champions / launcher

This is the launcher for w3champions. It includes the needed flo hostbot executables.
32 stars 18 forks source link

W3C-205 Fix Close of Maximized Launcher; Remember Maximized State #160

Closed mikellalec closed 2 months ago

mikellalec commented 1 year ago

Note: Potentially some flaky behavior related to Electron Store (or hotswap)? Had wanted to squash my commit / re-created the PR for some linter build failures, for whatever reason seemed like the issue had re-appeared? Hoping a reviewer can confirm.

Longer context/investigation on the JIRA task, issue is related to the transparent launcher window and Electron 11.

With a workaround implementation of isMaximized(), it's possible to correctly maximize() as needed before hiding the launcher. Chose to call original maximize() before the hide() and not add the other workaround implementations for minimal addition.

Even with workaround - including getWindowBounds() caused the freeze again. When the Windows native maximize is used to maximize the transparent window, resized event is not triggered. Updating the bounds on resize for the maximize (the double-click) resolves the issue again.

Store the state of whether the launcher was maximized before hiding. Restoring from the tray is a show event - check if the user had their launcher maximized and maximize it if so.

gustav87 commented 2 months ago

Thanks for the contribution, but we're not accepting pull requests for the old launcher. It's deprecated.