search

w3champions / launcher

This is the launcher for w3champions. It includes the needed flo hostbot executables.
32 stars 18 forks source link

Indicate which icons/abilities cannot be moved #45

Closed Cepheid-UK closed 4 years ago

Cepheid-UK commented 4 years ago

Some of the Warcraft 3 abilities cannot be moved around on the command card (e.g. Gargoyle Prioritize)

It would be nice if we could catalogue those abilities and label them as unmovable in the UI somehow.

modmoto commented 4 years ago

Do you have the data? If you have it, I can code something up. Not that hard, to be honest. But I do not want to go through the abilities one by one xD

Cepheid-UK commented 4 years ago

You can search through customkeys.txt, if they have a "buttonpos" field, they can be moved.

At least that's what I've been reported. (Source: Ag3nt)

modmoto commented 4 years ago

you mean in the default hotkeys? Also pretty tedious imo :/ Those are 500 hks or so that i would have to go through. Maybe I ask Ag3nt if he wants to do that and give me the data.

Cepheid-UK commented 4 years ago

I'll try figure out which ones it is, but really I anticipated parsing a default custom hotkeys for all the 4-digit codes that don't have a "buttonpos" field and then flagging those codes as unmovable.

modmoto commented 4 years ago

yes, not that hard, but we have a tree structure to represent the ui. So you would at least have to go through those to mark the ones that are not movable. IT is basically those files here:

https://github.com/w3champions/w3champions-launcher/blob/master/src/hot-keys/RaceSpecificHotkeys/hotkeyData/nightelf/units.ts

I can make the code change and implement it for gargoyle. Then Ag3nt could go through those and mark the ones that he needs as a PR?

Cepheid-UK commented 4 years ago

Yes if you can implement the flag once, I can add it as a PR for the ones ag3nt has found.

modmoto commented 4 years ago

Hey, I just pushed this feature to the branch "Hotkey-Fixes". If you want to participate there, or ask Ag3nt, should be pretty easy. To mark a Ability as not movable, replace Ability.Create('Prioritize', 'btnairattackon', 'aatp', 'R', []), with Ability.Unmovable('Prioritize', 'btnairattackon', 'aatp', 'R', []),

modmoto commented 4 years ago

closed with https://github.com/w3champions/w3champions-launcher/pull/47