search

w3champions / launcher

This is the launcher for w3champions. It includes the needed flo hostbot executables.
32 stars 18 forks source link

Add authentication #77

Closed modmoto closed 3 years ago

abeninski commented 3 years ago

Note that we need blizzard auth with china id as well

modmoto commented 3 years ago

Good point. Do you know how we could test that? According to the specs, the oauth worklflow works everywhere, selecting the gateway only changes the response time. But could be possible that we have issues in china then. That should be avoided of course.

abeninski commented 3 years ago

There is a separate endpoint for china image https://develop.battle.net/documentation/guides/using-oauth https://develop.battle.net/documentation/battle-net/oauth-apis-cn

modmoto commented 3 years ago

ah great, thanks for that.

modmoto commented 3 years ago

Do you have a cn account? Because I think they are authenticating against netease in the background. At least I can not use my EU account for china. Do you know if they can login on the EU URL? I mean this also would be a problem on the website and should be fixed.

abeninski commented 3 years ago

They cannot login with on eu for sure. @fluxxu might be able to help with this

modmoto commented 3 years ago

gonna built this to test with cn guys