search

w3champions / website

The webpage for the www.w3champions.com community project.
49 stars 57 forks source link

Tournament bracket ui broken #439

Closed amacado closed 1 year ago

amacado commented 2 years ago

The /tournaments page seems to be broken (no bracket is visible at all): image

This is caused by several undefined index and duplicate keys bugs which I was able to fix in #437.

After the UI fix the bracket is shown again, but the connectors are not in the right place as you can see here: image

I was able to trace the bug and wonder if this has worked in the past. Because if I traced it right, the website backend's endpoint /api/tournament which is returning the TournamentRound object as property of the Tournament object do not contain the dimensions property which, is accessed in the UI (to calculate the connectors).

While I think it's not be best idea to return data which is used in the UI for DOM manipulation, it does not even provide this data. I might traced it wrong, so please feel free to correct me.

Cepheid-UK commented 2 years ago

@abeninski designed this UI so I'm not that familiar with how its supposed to work, but even this is an improvement right now.

The reason I haven't prioritised this fix is because we're going to completely replace the tournaments view once automated tournaments are here.

It will display info about upcoming/current/completed automated tournaments, and I think it may be best to leave the end-of-season tournaments on liquipedia with a sidebar component.

If you want to be involved in that design @amacado you're most welcome. Kenshin on discord has some good design ideas for displaying this data, and I dont even think we have a fixed api design either.

zygissss commented 2 years ago

done