search

w3champions / website

The webpage for the www.w3champions.com community project.
47 stars 54 forks source link

Fix missing lodash functions #644

Closed Rotzbua closed 1 year ago

Rotzbua commented 1 year ago

Fixes

Hero chart is broken.

Explanation

Minifying build size does not work properly with _.chain(). Some functions are not available at runtime due lazyness. Replaced chain.

Reference

Fixes previous PR #639

Rotzbua commented 1 year ago

@gustav87 lol that timing 😆

gustav87 commented 1 year ago

Oh no. We worked on this simultaneously it seems. Sorry about that. https://github.com/w3champions/website/pull/643

gustav87 commented 1 year ago

And commented simultaneusly. We got to stop this :D

gustav87 commented 1 year ago

I first tried using lodash/fp instead of creating lots of intermediate variables, but:

  1. It didn't work properly and
  2. It most likely convolutes the code too much anyway