w3ctag / design-reviews

W3C specs and API reviews
Creative Commons Zero v1.0 Universal
332 stars 56 forks source link

WebXR Lighting Estimation #574

Closed alcooper91 closed 3 years ago

alcooper91 commented 3 years ago

HIQaH! QaH! TAG!

I'm requesting a TAG review of the WebXR Lighting Estimation API

"Lighting Estimation" is implemented by AR platforms using a combination of sensors, cameras, algorithms, and machine learning. Lighting estimation provides input to rendering algorithms and shaders to ensure that the shading, shadows, and reflections of objects appear natural when presented in a diverse range of settings.

Further details:

You should also know that...

N/a

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

torgo commented 3 years ago

Hi @alcooper91! Thanks for this review request. We note that the response to privacy & security section is great. One thing we felt was missing was the mitigation information on fingerprinting- which is actually discussed in the privacy & security considerations section of the explainer. And it also seems like there are requirements in the explainer - e.g. quantization - which do not actually appear in the spec itself? From a functional point of view the proposal seems like a great addition to XR.

alcooper91 commented 3 years ago

Hi @torgo, I can certainly add a line to the Privacy section of the spec recommending quantization of the Spherical Harmonics and Primary Light Direction, I believe that was just a simple omission when trying to distill the key requirements from the explainer; but I'm not sure I understand what the first ask (about the fingerprinting mitigations) is, assuming it is separate from adding the quantization. Are you referring to the "How does this specification deal with sensitive information?" section of the security and privacy questionnaire?

Apologies for not responding sooner, it seemed that the only request was to simply add the additional quantization information.

alcooper91 commented 3 years ago

immersive-web/lighting-estimation#45 Adds the requested line about quantization to the spec.

torgo commented 3 years ago

Thanks for that! To clarify, the quantization was the same as the fingerprinting mitigation issue, yes. Thanks for responding to this feedback and being aware of these issues.

torgo commented 3 years ago

We're happy to close this off now. Thanks for filing this and let us know if we can be of any more help.