search

w3ctag / design-reviews

W3C specs and API reviews
Creative Commons Zero v1.0 Universal
332 stars 56 forks source link

Review Request for CSS Color Adjust Level 1 #583

Closed fantasai closed 3 years ago

fantasai commented 3 years ago

HIQaH! QaH! TAG!

I'm requesting a TAG review of CSS Color Adjust Level 1. This module introduces a model and controls over automatic color adjustment by the user agent to handle user preferences, such as "Dark Mode", contrast adjustment, or specific desired color schemes.

Further details:

You should also know that... we're not thrilled with the very generic name of the color-adjust property, but at this point it's been shipping for too long to change. :(

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback

tabatkins commented 3 years ago

Explainers

This specification introduces three new features related to controlling how/when colors are auto-adjusted in certain ways:

The color-scheme property is part of the larger cross-spec definition of Color Scheme support, aka “Dark Mode”. The WebKit team posted a reasonable explainer about the overall feature in https://webkit.org/blog/8840/dark-mode-support-in-webkit/. OSes now widely implement the ability to capture and reflect a user's preference for “light” vs “dark” UI, and this information is presented to a web page via the (prefers-color-scheme) media query, allowing a page to choose different colors and images to honor the user's preference. Some parts of the page are styled and rendered by the browser, however, such as form controls and scroll bars, and thus can't be directly restyled by the page author. The 'color-scheme' property negotiates between the uses’s preferred color schemes vs. author-supported / preferred color schemes.

This is necessary to expose as a control, rather than just part of the default behavior of the browser, because the vast majority of pages on the web were authored before color scheme support existed, and thus are generally authored with colors chosen to work well with the (reasonably consistent) set of "default" input/scrollbar/etc colors. Changing this unilaterally on pages has a small but serious chance of rendering these widgets difficult to see or use due to the colors the page is already using. A more common but less destructive issue is that making scrollbars and form controls dark, but keeping the rest of the page in the author-specified colors (usually very light) wouldn't actually achieve anything useful for most pages, and would end up just making pages look awkwardly composed for no benefit to the user.

"Forced Colors Mode" is a special accessibility mode exposed by some OSes, most notably Microsoft Windows via its High Contrast Mode feature. This can be thought of as a stronger version of a preferred color scheme: rather than simply preferring a lighter or darker UI, the user is requesting that the OS use only a chosen set of colors. Usually this is used to force a "high contrast" UI (thus the name of the windows feature) for people with impaired vision, but it can be used for a number of other color needs, such as forcing a low contrast color scheme (which helps with some sensory processing issues). Microsoft provided a great explainer for this feature in https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Accessibility/HighContrast/explainer.md.

This color scheme is forced on a webpage regardless of whether it was authored with the expectation of its colors being adjusted. https://drafts.csswg.org/css-color-adjust/#forced-colors-properties defines precisely which properties are affected, and how. The short explanation is that the system color keywords are set to the user's chosen colors, and any property using a color other than those keywords is instead forced into one of the keywords.

This can be a fairly destructive process; most pages will still be usable, but it can occasionally cause problems, for which several mitigations are described. The first, whose definition in CSS is deferred to the next level of this spec, is a "backplate" for text, which ensures that text displayed over background images will still be readable. The second is that authors can directly use the system color keywords to style their pages, either unreservedly or gated behind the (prefers-contrast: forced) media query, and have those color choices respected, even if they're different than what the given properties would normally be forced to. The third is the forced-color-adjust property, which allows authors to turn off the Forced Colors feature for an element when absolutely necessary (when the chosen colors are meaningful and required for the page to make sense, for example, for color swatches).

Similar to Forced Colors Mode, user agents sometimes automatically adjust a page's colors to match the user's assumed preference in certain circumstances. For example, use of near-black text over a near-white background is common on the web, but ruinous when printing - printing pure black text is often cheaper and sharper than colored text that is nearly black, and large tracts of background color are expensive to print and sometimes destructive to the paper itself (particular with inkjets). Browsers commonly default to using heuristics to tell when it would be okay to just ignore the author's chosen colors and instead print as black-on-white, which is better for the user. They sometimes provide UI to the user to let them opt into printing exactly what's on the screen, but it's often buried deep in the print UI if it's exposed at all.

These heuristics can sometimes misfire, resulting in unreadable text/background combinations. Also, backgrounds and other colors are sometimes very useful to the user even when printing: for example, Google Maps "zebra stripes" the steps of its navigation directions to make it easier to read, alternating between a white and light gray background. The color-adjust property allows a page to specify that this sort of automatic adjustment should not be performed, and instead the exact colors specified by the author should be preserved. https://wiki.csswg.org/ideas/print-backgrounds lays out our decision history for the design of this functionality (which later carried over to the forced-color-adjust property, which is virtually identical).

alisonmaher commented 3 years ago

As a quick note on time constraints, we are planning to ship the Forced Colors Mode feature in full form in Chromium soon. Given this, we'd appreciate a review of Forced Colors Mode in particular if possible.

alisonmaher commented 3 years ago

I wanted to follow-up in this thread with a clarification since there was some confusion raised around what is included in the review for Forced Colors Mode, specifically around the various media queries.

The main two properties that we were planning on shipping initially are forced-color-adjust and the forced-colors media query.

The prefers-contrast media query currently does include a forced value that would match in Forced Colors Mode, but we weren't planning to ship with this media query initially given that there are open discussions around the syntax and whether the forced value should be included. Our plan was to ship this separately once the open issue has been resolved.

There was consensus, however, that we would be keeping the forced-colors media query as a part of the spec regardless of what happens with prefers-contrast: forced, which is why it's included in our initial feature scope.

alice commented 3 years ago

We discussed this in a breakout today.

The forced-colors media query and forced-color-adjust certainly seem like good solutions to a real problems (respectively, how to know when colors are being overridden because of a user preference, and how to opt out of that in rare cases when necessary).

We noted that there is an issue in the spec about merging color-adjust and forced-color-adjust. It's not clear to me why forced-color-adjust: none couldn't be used in any case where color-adjust: exact might be used. In either case, you are opting out of colors being adjusted, and in fact it might well be necessary to apply both in cases like the swatches example, or even the zebra stripes example, and using media queries to select for specific media such as print where you want colors to be overridden in one medium but not another.

color-schemes was also a bit confusing going only on the spec; having re-read Tab's comment above I now understand it better. In particular, the code examples don't really clarify much, since they're identical. It would also be helpful to have some examples which demonstrate the failure case which occurs when this property isn't available.

One thing that I note is that "normal" is more or less synonymous with "light", in practice. Why have two values which mean roughly the same thing? Could "normal" be replaced with "light" as the default?

alice commented 3 years ago

Accidentally closed, somehow.

hober commented 3 years ago

Hi @fantasai, @TabAtkins!

Hadley, Lea, and I took another look at this during a breakout this week. Overall we're happy with this set of features that solve a number of real problems. @alice raised a number of points, and we see that the WG has considered each of them.

Thanks for bringing this to us!