w3ctag / design-reviews

W3C specs and API reviews
Creative Commons Zero v1.0 Universal
326 stars 55 forks source link

Auto-expanding details elements #677

Closed josepharhar closed 2 years ago

josepharhar commented 3 years ago

Ya ya yawm TAG!

I'm requesting a TAG review of Auto-expanding details elements.

Summary: Today, closed details elements aren't searchable by find-in-page or ScrollToTextFragment, and if a user wants to search in them with find-in-page they would have to manually open every details element in the page before beginning their search. This feature makes closed details elements searchable and automatically expands them when the browser tries to scroll to content inside of them for find-in-page, ScrollToTextFragment, and element fragment navigation.

Further details:

We'd prefer the TAG provide feedback as (please delete all but the desired option):

💬 leave review feedback as a comment in this issue and @-notify [github usernames]

josepharhar commented 2 years ago

There is some useful discussion here: https://github.com/mozilla/standards-positions/issues/578

torgo commented 2 years ago

Hi @josepharhar. Regarding the security & privacy questionnaire - you've noted a privacy venerability and a potential mitigation. (Great!) Is this documented anywhere in the spec itself? We are generally supportive - we just want to bottom out the potential privacy issue that you've documented. Also adding privacy-tracker label to bring it to the attention of Privacy Interest Group.

josepharhar commented 2 years ago

you've noted a privacy venerability and a potential mitigation. (Great!) Is this documented anywhere in the spec itself?

No, I didn't include this in the spec

slightlyoff commented 2 years ago

hey @josepharhar, per the Intent thread, it'd be great to see a non-normative note in the spec flagging that this is a potential concern, perhaps in your privacy and security considerations section?

Thanks.

josepharhar commented 2 years ago

hey @josepharhar, per the Intent thread, it'd be great to see a non-normative note in the spec flagging that this is a potential concern, perhaps in your privacy and security considerations section?

I opened a PR to add a non-normative note here: https://github.com/whatwg/html/pull/7229

torgo commented 2 years ago

Thanks @josepharhar and @slightlyoff - much appreciated. I think on that basis we're happy to close the review. We discussed this last week and we have no objections. Thanks for flying TAG.