w3ctag / design-reviews

W3C specs and API reviews
Creative Commons Zero v1.0 Universal
326 stars 55 forks source link

Web of Things (WoT) Discovery #733

Closed mmccool closed 2 years ago

mmccool commented 2 years ago

Ready for review, however WD update still pending. In the meantime the following branch should be used for review: review-pre-cr-wd.

Braw mornin' TAG!

I'm requesting a TAG review of Web of Things (WoT) Discovery

WIP: [One paragraph summary of idea, ideally copy-pasted from Explainer introduction]

Further details:

You should also know that...

We'd prefer the TAG provide feedback as (please delete all but the desired option):

🐛 open issues in our GitHub repo for each point of feedback


CAREFULLY READ AND DELETE CONTENT BELOW THIS LINE BEFORE SUBMITTING

Please preview the issue and check that the links work before submitting.

In particular, if anything links to a URL which requires authentication (e.g. Google document), please make sure anyone with the link can access the document. We would prefer fully public documents though, since we work in the open.

¹ We require an explainer to give the relevant context for the spec review, even if the spec has some background information. For background, see our explanation of how to write a good explainer. We recommend the explainer to be in Markdown.

² A Security and Privacy questionnaire helps us understand potential security and privacy issues and mitigations for your design, and can save us asking redundant questions. See https://www.w3.org/TR/security-privacy-questionnaire/.

rhiaro commented 2 years ago

Overall, the direction of this looks good. The two-stage discovery process seems sensible to us. What use cases can be met after only carrying out the first step?

We note that you have deferred work on geolocation queries. This is something we will be very interested to review in the future from a privacy and security, and general social impact, perspective. We would welcome early review requests on this as your draft progresses.

The related work section in your explainer contains references to other work but without any links. Could you add some?

Please also see the review for the Architecture specification as this contains feedback that concerns all of the related specs.

rhiaro commented 2 years ago

@mmccool We are closing this review request, but when you have chance to respond to my earlier question or make the improvements to the explainer, please ping me here. Thanks!

mmccool commented 2 years ago

Response from WoT Discovery TF (call Aug 1; sorry, last week we had no meeting):

  1. Use cases for first phase. There are not any; some "exploration mechanism" must be used to access metadata. Introductions are intentionally designed to reveal as little information as possible since in general they are unauthenticated. Although I suppose someone could infer that something in the area supports WoT Discovery, so there might be some "unintentional" use cases.
  2. Agree about geolocation, we are in extensive discussion with SDW and OGC on this.
  3. Regarding links to related work in the explainer: there are already a lot of links in the document itself. For now we have just updated the explainer to note that there are many links in the document itself, but we will look for a survey article or two to add, such as the following (although then we may want to add these to the main document as well).