w3ctag / design-reviews

W3C specs and API reviews
Creative Commons Zero v1.0 Universal
328 stars 55 forks source link

Add Skip-Ad media session action #957

Closed jiajiabingcheng closed 1 week ago

jiajiabingcheng commented 4 months ago

こんにちは TAG-さん!

I'm requesting a TAG review of Adding Skip-Ad media session action.

This feature was initially proposed and implemented four years ago but remained disabled due to a lack of practical use cases. It already received LGTM from the Blink dev group back in February 2019. Given our team's plan to implement a feature related to this action, we are now proposing to enable it.

Further details:

You should also know that...

[please tell us anything you think is relevant to this review]


CAREFULLY READ AND DELETE CONTENT BELOW THIS LINE BEFORE SUBMITTING

Please preview the issue and check that the links work before submitting.

In particular, if anything links to a URL which requires authentication (e.g. Google document), please make sure anyone with the link can access the document. We would prefer fully public documents though, since we work in the open.

¹ We require an explainer to give the relevant context for the spec review, even if the spec has some background information. For background, see our explanation of how to write a good explainer. We recommend the explainer to be in Markdown.

² A Security and Privacy questionnaire helps us understand potential security and privacy issues and mitigations for your design, and can save us asking redundant questions. See https://www.w3.org/TR/security-privacy-questionnaire/.

³ For your own organization, you can simply state the organization's position instead of linking to it. Chromium doesn't have a standards-positions repository and prefers to use comments from the teams that maintain the relevant area of their codebase.

torgo commented 1 month ago

Just a quick note - and noting this is not formal TAG feedback, but a question that came up in our discussion in this morning's breakout call where we discussed this: could this API could be generalized so that it's not specifically referencing advertizing but more the general use case of skipping an intro or skipping "to the main content"? It feels like there are multiple cases where this could be used that are not advertizing related, and also we don't currently have other APis in the platform that are just supporting advertising.

martinthomson commented 1 month ago

Along the lines that @torgo mentions, it occurs to me that video services often have the ability to skip an intro sequence. This fills a similar function, so if you are looking for generality, that might be worth looking into.

martinthomson commented 3 weeks ago

Firstly, we need to ask whether this was implemented in browsers other than Chrome. If it wasn't, this presents an opportunity to improve it.

One desire we have is to make this feature generic, rather than being specific to skipping ads.

We observe that the Media Chapter information (that we recently reviewed) might provide a useful hook for this sort of control. "Chapters" that are skippable can be marked as such in that metadata. The type of thing to skip might be included in that information. Consider { ..., skippable: "ad" }. That would allow for skipping of intro sequences and credits in addition to ads.

For accessibility purposes, this sort of thing might need to be given a symbol so that non-textual users are able to more readily access the function. Please consult an accessibility expert about this (@matatk indicated that APA is likely to want to take another look; it's been a while since they reviewed the original MediaSession proposal).

miketaylr commented 3 weeks ago

Firstly, we need to ask whether this was implemented in browsers other than Chrome. If it wasn't, this presents an opportunity to improve it.

Looks to be implemented in Gecko for quite some time:

https://searchfox.org/mozilla-central/source/dom/webidl/MediaSession.webidl#16-26 https://bugzilla.mozilla.org/show_bug.cgi?id=1582569

chrisn commented 3 weeks ago

I very much agree with https://github.com/w3ctag/design-reviews/issues/957#issuecomment-2328129458 that a more generic skip action would be useful.

martinthomson commented 2 weeks ago

I just opened https://github.com/w3c/mediasession/issues/340 to track that proposal.

matatk commented 1 week ago

Thanks for the review request. As this is shipping in multiple engines, and our concerns have been raised in an issue to be addressed in future, we'll close this review.