Closed cynthia closed 7 years ago
@cynthia the point is that ideally, you have some form of feature detection logic that avoids serving those polyfills in the more recent browsers. I'm trying to solve the problem that, at the extreme, could mean megabytes of unnecessary code on the page. Take Intl
, for example - the full polyfill with all locale date for all locales is over 20MB.
I agree that shipping this would be ludicrous but believe me I have polyfill.io server logs to prove people do it, and they even force us to serve it to browser that have it natively.
I'll see if there is a better way to word this.
Reviewed at F2F. @cynthia is not here but we agreed to reflect slightly more nuance in the wording. See https://github.com/w3ctag/polyfills/commit/fa5c8f4a3597f7c8a7457a4d33f14172ee41172c#diff-eacf331f0ffc35d4b482f1d15a887d3bL205
Thanks for taking care of this. Looks good.
This warning would be implementation (e.g. browser version) specific, not entirely sure if it would be extremely beneficial to the developer.
There is a chance of it eventually being treated as noise, since if your ship targets include say, old versions of IE it's going to always show up in the log.