w3f / LightClient

LightClient
1 stars 0 forks source link

Incorporating CCS23 feedback/comments part I #2

Open InaOana opened 1 year ago

InaOana commented 1 year ago
  1. Sec 3.3: Motivation/intuition for the formalization of the properties perfect completeness, soundness, and unforgeability is missing. Why do these capture what should be achieved?

  2. p. 7: forgecomkey game: pk \neq pk \land bit_i =0: should \land be \lor? Seems like the implication (pk=pk) -> bit_i=0 is desired here?

  3. p. 9: "while the R_ba^incl relation is defined using" -> should it be "pa" here?

  4. p. 9, 11: No intuition/motivation is provided for the stated polynomial identities.

  5. p. 12: "If this holds": should it be "if this doesn't hold"?

  6. Typos ...

  1. It would be best if you explain the intuition of how the SNARK is being tailored before diving into constructing identity polynomials.
  2. Extra “and” - last sentence of page 9.
  3. Would be best to explain the unforgeability game in a couple of sentences first before giving a formal definition.
  4. The identify polynomials are not explained well, the logic for defining them is unclear. It would be best to give intuition behind their constructions.
InaOana commented 1 year ago

@AlistairStewart, @FatemeShirazi, I have tackled the reviewers' comments found in the first 3 items above and would appreciate any feedback you have. My updates have been marked/added as red text to this folder. The 4th item needs more time and I will not tackle it this week. Thank you.