Open AndreasGassmann opened 3 years ago
@AndreasGassmann Hi, sorry for the delayed response. I went through the document and have some initial thoughts (good document, overall):
id
be an integer rather than a string?MessageType
should be separated into two types: one for requests and one for responses (which results in changes to BaseMessage
, respectively).
”broadcast_request”
means exactly.BaseMessage
should probably not list fields like type
, version
, id
and senderId
again (I might be interpreting this wrongly, I haven't interacted with TypeScript that much).network
into BaseMessage
?
BaseMessage
should therefore remove the network
field.NetworkType
is unspecified.Network.rpcUrl
is passed on, maybe mentioned that it must comply with some sort of standard?PermissionScope
is missing ”broadcast_request”
.
This PR adds a draft for the wallet interaction standard.