search

w3f / PSPs

Polkadot Smart Contract Proposals
Creative Commons Zero v1.0 Universal
158 stars 68 forks source link

PSP-34: Non Fungible Token standard (WASM ERC721) adoption process - 2 #39

Closed xgreenx closed 2 years ago

xgreenx commented 2 years ago

Hello there!=)

It is the second adoption process, the first was: https://github.com/w3f/PSPs/pull/36 But after the creation of the proposal for Multi token, we realized, that the NFT proposal can be improved and API will be consistent. About the improvement, you can read in that proposal: https://github.com/w3f/PSPs/pull/38

That PR is created to have a space for the discussion of this standard.

At this point in time, the standard is in Call for Feedback status. Accepted is the next stage.

The Supercolony team will be leading the process of adoption. We are going to involve every meaningful stakeholder we know so that this standard is built fully and nothing is missed. We will update this PR with any change that will be agreed upon here or in any other channel.

Please do invite anyone who is interested in the NFT for the WASM contract!=)

hoonsubin commented 2 years ago

I have a question regarding the NFT ink contract. So, we have a dedicated NFT module as part of ORML (https://github.com/open-web3-stack/open-runtime-module-library/tree/master/nft) and RMRK on Kusama. How will PSP-34 fit in all this? For example, will there be a generic way to swap from one network to another (like when using XCM), and will it be possible to create an NFT marketplace that can list any types of NFTs?

xgreenx commented 2 years ago

I have a question regarding the NFT ink contract. So, we have a dedicated NFT module as part of ORML (https://github.com/open-web3-stack/open-runtime-module-library/tree/master/nft) and RMRK on Kusama. How will PSP-34 fit in all this?

Hi, that proposal aims to be compatible with uniques-pallet. The RMRK has another scope of usage and is more complicated and heavy(the smart contract will take more size). It requires a separate standard.

For example, will there be a generic way to swap from one network to another (like when using XCM), and will it be possible to create an NFT marketplace that can list any types of NFTs?

The contract that implements this proposal does not need to send XCM messages by itself. It can, but it requires async handling of them. Instead, the contract can be implemented via uniques-pallet. If uniques-pallet supports XCM(it is in the roadmap of Parity) then the NFTs from the contract also can be teleported to another paracahin by a separate action.

The proposal is an interface, the implementation can use uniques-pallet or can be implemented on the smart-contract level. But it should not affect the NFT marketplace or other contracts.

lamafab commented 2 years ago

FYI: https://github.com/w3f/PSPs/commit/3e6d514def7a90f48664ddfcc80c21f9668305cf