search

w3f / PSPs

Polkadot Smart Contract Proposals
Creative Commons Zero v1.0 Universal
158 stars 68 forks source link

PSP34 Transfer event parameter "from" is unnecessary #69

Open Nradko opened 9 months ago

Nradko commented 9 months ago

In PSP34 the Transfer event possesses field "from" that is unnecessary.

One can always deduce the previous owner of a token with an ID based on the previous Transfer event that contains the ID. If such a previous event doesn't exist it means that the token hasn't been minted.

I would recommend changing the standard. Changes to events should not break the cross-contract calls. Also If one assumes the new standard in one's off-chain application the application will be compatible with the previous standard as long as one allows the field "from" to be undefined.

deuszx commented 9 months ago

I have to disagree that it's unnecessary. Events are often observed in isolation so information about past events are not readily available. Not all indexers/event listeners have access to the previous Transfer event that could have happened months/years ago.