search

w3f / polkadot-spec

The Polkadot Protocol Specification
https://spec.polkadot.network
Creative Commons Attribution Share Alike 4.0 International
179 stars 70 forks source link

Beefy Light client is not supposed to have access to the public keys of the validators #658

Closed drskalman closed 1 year ago

drskalman commented 1 year ago

@AlistairStewart noticed this line in the spec of light client:

The light client is expected to know who the validators are and has access to their public keys.

This is not how BEEFY light client supposed to work. It does have access to the a commitment to the set of validator publickeys which is not mentioned in the spec and should be mentioned. In contrast in both ECDSA and APK proof BEEFY it does not have immediate access to the public keys so the statement is not correct.

bhargavbh commented 1 year ago

Just confirming if you are referring to 6.7.1 (https://spec.polkadot.network/sect-finality#defn-beefy-light-client) and not in the light client chapter. Further, I would also suggest changing the name in definition from 'Light Client' to 'Beefy Light Client'.

bhargavbh commented 1 year ago

addressed in Beefy PR here https://github.com/w3f/polkadot-spec/pull/682