search

w3f / polkadot-spec

The Polkadot Protocol Specification
https://spec.polkadot.network
Creative Commons Attribution Share Alike 4.0 International
180 stars 70 forks source link

Revert "Fixup merkle-value" #702

Closed tjjfvi closed 1 year ago

tjjfvi commented 1 year ago

Reverts #698

As discussed in the comments of that PR, the behavior described before by the spec was correct – a node is inlined only if len < 32.

bkchr commented 1 year ago

IMO we should maybe just get rid off this merkle value. This is used no where in the spec and I only see it bringing confusion, than any help in understanding the spec or whatever.

tjjfvi commented 1 year ago

It is referenced here, in the definition of the subvalue of a trie node.

tjjfvi commented 1 year ago

@Noc2 Thanks; I would definitely be open to joining the committee. (I have been working on implementing the protocol, and do plan to contribute fixes back to the spec when I have time.)