w3f / polkadot-spec

The Polkadot Protocol Specification
https://spec.polkadot.network
Creative Commons Attribution Share Alike 4.0 International
180 stars 70 forks source link

Spec suggests using wrong substream for fetching state information #723

Closed vikinatora closed 2 months ago

vikinatora commented 2 months ago

In the spec, it's said that /sync/2 is used for block requsests and state requests. However, that substream is only good for fetching block information. We tried countless ways of sending a state request but the response just didn't arrive. After lots of hours spent trying to find out why state requests don't work, we stumbled upon Kagome's code, where we found out there's another undocumented substream /state/2 that's used for making state requests.

We suggest adding this substream to the spec because it's not documented and changing the existing spec to point to the new substream for state requests.

bhargavbh commented 2 months ago

hi @vikinatora thanks for bringing this to our attention. We will look into it ASAP.

bhargavbh commented 2 months ago

adressed in PR https://github.com/w3f/polkadot-spec/pull/724