w3f / polkadot-spec

The Polkadot Protocol Specification
https://spec.polkadot.network
Creative Commons Attribution Share Alike 4.0 International
180 stars 70 forks source link

Definition 154 is mistaken #725

Open josepot opened 2 months ago

josepot commented 2 months ago

There are a few issues with definition 154:

1) The link to the "external SS58 address format" is broken. 2) The reference to SS58 address format is IMO completely unnecessary, as the SS58 format is just a possible representation of the bytes of the address. In other words, the SS58 format is just derived from the bytes of the address, the only thing that's relevant are the actual bytes. 3) Since transaction version 2 the address is in fact a MultiAddress. Therefore, Ai is not a 32 bytes address but rather a multi-address variant which should be properly defined. ​