search

w3f / polkadot-validator-setup

Polkadot Validator Secure Setup
Apache License 2.0
217 stars 130 forks source link

Replace dash with underscore in Ansible inventory naming convention #128

Closed lamafab closed 3 years ago

lamafab commented 3 years ago

Replace dash with underscore in Ansible inventory naming convention. For example, from [validator-0] to [validator_0].

This change avoids printing the following warning when executing the Ansible script:

[DEPRECATION WARNING]: The TRANSFORM_INVALID_GROUP_CHARS settings is set to allow bad characters in group names by default, this will change, but still be user configurable on deprecation. This feature will be removed in version 2.10. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[WARNING]: Invalid characters were found in group names but not replaced, use -vvvv to see details
ironoa commented 3 years ago

Thanks @lamafab

Heads up, this change involves also a modification in this file for instance (the NodeJs layer): https://github.com/w3f/polkadot-validator-setup/blob/master/tpl/ansible_inventory#L2

Could you double check that please ?