search

w3f / polkadot-wiki

The source of truth for Polkadot.
GNU General Public License v3.0
373 stars 2.3k forks source link

links are incorrect after refresh page #2250

Closed lovelangy closed 3 years ago

lovelangy commented 3 years ago

reproduce step:

  1. open getting-started page. https://wiki.polkadot.network/docs/getting-started
  2. move mouse to 'Creating a Polkadot Account', verify the link is 'https://wiki.polkadot.network/docs/learn-account-generation/', which is correct.
  3. Refresh the getting-started page, the url will be 'https://wiki.polkadot.network/docs/getting-started/'
  4. move mouse to 'Creating a Polkadot Account', verify the link is 'https://wiki.polkadot.network/docs/getting-started/learn-account-generation', which is deadlink.

this happens to whole website, not just getting-started page

emresurmeli commented 3 years ago

I noticed the same thing on https://wiki.polkadot.network/docs/learn-accounts/ when you click "the cryptography page" in the first sentence which links to https://wiki.polkadot.network/docs/learn-accounts/learn-cryptography but should be https://wiki.polkadot.network/docs/learn-cryptography

nam-hle commented 3 years ago

Hi @emresurmeli, I think the issue due to the way we refer other documents. From Docusaurus, the recommendation is to include the file extension when referencing.

salmad3 commented 3 years ago

search and some links on the Kusama guides also going to "Page Not Found"

emresurmeli commented 3 years ago

@nam-hle Is this something that can be fixed by updating the config or? I think we have a lot of places outside of the wiki that link to these pages, and so we need to be careful about those not breaking.

nam-hle commented 3 years ago

The issue is not fixed. The Docusarus maintainer said we need to add .md when referencing.

salmad3 commented 3 years ago

Right sorry just noticed only a few working - @nam-hle we should just update all references I assume? If so, will make it a high priority

salmad3 commented 3 years ago

Looks it solves the issue - will update now

salmad3 commented 3 years ago

Merged PR as priority fix as there has been a number of folks pointing out the links not working - don't hesitate to review or reopen if not fixed.

salmad3 commented 3 years ago

@nam-hle seems like link issue persists

nam-hle commented 3 years ago

Sorry for my delay. The job takes me too much energy. I check again the issue, maybe it's resolved somehow, isn't it?

salmad3 commented 3 years ago

It seems like it is...

salmad3 commented 3 years ago

The WikiOps issue can serve as a reference point, closing this